Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6664] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n #6674

Conversation

mtoader
Copy link
Contributor

@mtoader mtoader commented Aug 28, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Issue number: #6664 (#6664)

Description of this change

This adds ExternalWorkspaceDataProvider to pull the output of blaze mod dumo_repo_mapping from the sync process and in memory.

This should be latest bit of "wiring". The next PR should start changing the external reference fragment for completion / resolving.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 28, 2024
@mtoader mtoader marked this pull request as draft August 28, 2024 21:18
@mtoader
Copy link
Contributor Author

mtoader commented Aug 28, 2024

Marking as draft since i can't seem to find a decent way of stacking it on #6673

@mtoader mtoader changed the title Mtoader/add external workspace data provider to sync [bazelbuild#6665] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n Aug 28, 2024
@mtoader mtoader changed the title [bazelbuild#6665] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n [#6665] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n Aug 28, 2024
@mtoader mtoader force-pushed the mtoader/add-external-workspace-data-provider-to-sync branch 7 times, most recently from 1fc5b40 to 3279f70 Compare August 29, 2024 20:13
@mtoader mtoader marked this pull request as ready for review August 29, 2024 20:13
@mtoader mtoader force-pushed the mtoader/add-external-workspace-data-provider-to-sync branch from 3279f70 to 35ab1d7 Compare August 29, 2024 20:21
@mtoader mtoader changed the title [#6665] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n [#6664] Add a ExternalWorkspaceDataProvider and wire inside the sync - 3/n Aug 29, 2024
@mtoader mtoader force-pushed the mtoader/add-external-workspace-data-provider-to-sync branch from 35ab1d7 to e82f94d Compare August 29, 2024 20:34
@mtoader
Copy link
Contributor Author

mtoader commented Aug 29, 2024

This is also ready

@mtoader mtoader force-pushed the mtoader/add-external-workspace-data-provider-to-sync branch 2 times, most recently from 2474a92 to c89139e Compare August 30, 2024 00:38
@mtoader mtoader force-pushed the mtoader/add-external-workspace-data-provider-to-sync branch from c89139e to a8a4346 Compare August 30, 2024 00:39
@tpasternak tpasternak merged commit 0cd1de2 into bazelbuild:master Aug 30, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 30, 2024
@mtoader mtoader deleted the mtoader/add-external-workspace-data-provider-to-sync branch August 30, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants