fix go test not found problem

[ufo22940268]

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6427 #5455

Description of this change

When run go test with testify framework, the test won't be found with the test_filter parameter. But if we changed to use --test_arg=-testify.m=^TestUpdateSimpleTasksTeam_NoTeamIDSet$ then the test can be found correctly.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[sgowroji]

Hi @ufo22940268, Could you please Sign the CLA. Thanks!

[ufo22940268]

@sgowroji Seems like i have signed.

[tpasternak]

Hi, thank you for the contribution, but now running non-testify single test cases is broken

[tpasternak]

@ufo22940268
you could try doing it this way

diff --git a/golang/src/com/google/idea/blaze/golang/run/producers/GoTestContextProvider.java b/golang/src/com/google/idea/blaze/golang/run/producers/GoTestContextProvider.java
--- a/golang/src/com/google/idea/blaze/golang/run/producers/GoTestContextProvider.java	(revision ebd81d99b6a07a8e4043478a82a332a584a367d5)
+++ b/golang/src/com/google/idea/blaze/golang/run/producers/GoTestContextProvider.java	(date 1723542217361)
@@ -17,8 +17,10 @@
 
 import com.goide.execution.testing.GoTestFinder;
 import com.goide.execution.testing.GoTestRunConfigurationProducerBase;
+import com.goide.execution.testing.frameworks.testify.GoTestifySupport;
 import com.goide.psi.GoFile;
 import com.goide.psi.GoFunctionOrMethodDeclaration;
+import com.goide.psi.GoMethodDeclaration;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.idea.blaze.base.dependencies.TargetInfo;
@@ -103,6 +105,11 @@
       return null;
     }
     GoFunctionOrMethodDeclaration function = GoTestFinder.findTestFunctionInContext(element);
+    if(function instanceof GoMethodDeclaration method) {
+      if (GoTestifySupport.getTestifySuiteTypeSpec(method) != null) {
+        // is testify
+      }
+    }
     if (function == null) {
       return TestContext.builder(/* sourceElement= */ file, ExecutorType.DEBUG_SUPPORTED_TYPES)
           .addTestEnv(GO_TEST_WRAP_TESTV)

[ufo22940268]

I will try today

[ufo22940268]

@tpasternak I updated code and make the change compatible with existing cases. But i can't add test for testify, here is the the test i write, but it still won't recognize the gofile as testify test

  @Test
  public void testTestifyFile() throws Throwable {
    PsiFile goFile = setupWithSingleFile(
        """
            package yourpackage
            
            import (
                "testing"
                "github.com/stretchr/testify/suite"
            )
            
            // Define the test suite struct
            type YourTestSuite struct {
                suite.Suite
            }
            
            // Example test method
            func (suite *YourTestSuite) T<caret>estExample() {
                suite.T().Log("This is an example test")
                suite.Equal(1, 1, "They should be equal")
            }
            
            // Run the test suite
            func TestYourTestSuite(t *testing.T) {
                suite.Run(t, new(YourTestSuite))
            } 
            """
    );

    PsiElement element = getElementAtCaret(0, goFile);
    String expectedTestFilter = "^TestExample$";
    ConfigurationContext context = createContextFromPsi(element);
    List<ConfigurationFromContext> configurations = context.getConfigurationsFromContext();
    assertThat(configurations).isNotNull();
    assertThat(configurations).hasSize(1);

    ConfigurationFromContext fromContext = configurations.get(0);
    assertThat(fromContext.isProducedBy(TestContextRunConfigurationProducer.class)).isTrue();
    assertThat(fromContext.getConfiguration()).isInstanceOf(BlazeCommandRunConfiguration.class);

    BlazeCommandRunConfiguration config =
        (BlazeCommandRunConfiguration)fromContext.getConfiguration();
    assertThat(config.getTargets())
        .containsExactly(TargetExpression.fromStringSafe("//foo/bar:foo_test"));
    assertThat(Objects.requireNonNull(getTestArgsContents(config)).get(0)).isEqualTo(
        "-testify.m=" + expectedTestFilter);
    assertThat(getCommandType(config)).isEqualTo(BlazeCommandName.TEST);
  }

[tpasternak]

but does it work when you test it manually?

[ufo22940268]

yes

[tpasternak]

So I think it could indeed be non-trivial to use an external dependency in the current test framework, however we could try to create an empty go package that uses testify's importpath, and exposes a dummy Suite symbol.

intellij/golang/tests/integrationtests/com/google/idea/blaze/golang/resolve/BlazeGoImportResolverTest.java

Lines 63 to 75 in ebd81d9

	TargetMapBuilder.builder()
	.addTarget(
	TargetIdeInfo.builder()
	.setBuildFile(src("binary/BUILD"))
	.setLabel("//binary:main")
	.setKind("go_binary")
	.addSource(src("binary/main.go"))
	.addDependency("//library:foo")
	.addDependency("//library/bar:go_default_library")
	.setGoInfo(
	GoIdeInfo.builder()
	.addSource(src("binary/main.go"))
	.setImportPath("github.com/user/binary/main")))

[ufo22940268]

@tpasternak test added. please take another look.

[tpasternak]

@ufo22940268 thank you for the contribution!