feat: Enable debugging the gazelle binary #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebarrau
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: GoLand
|
LGTM. We checked internally, and it allows you to debug a gazelle target with a custom plugin from your own repository, which is a huge boon to gazelle plugin developers. FYI, the reason this has to be its own target kind is because Approving, but it's in such a core place that I'd like @mai93 's opinion. |
blorente
approved these changes
Dec 6, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow debugging gazelle (use the
gazelle_binarytarget and not thegazelleone).