Pass environment variables from BlazeCidrLauncher down to bazel #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujohnny
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
ujohnny
force-pushed
the
enovozhilov/env-vars-to-bazel-run-debug
branch
from
ef8d38c
to
8b5c0f8
Compare
ujohnny
changed the title
|
checked #2042 description and I think I have to remove the reference to it since environment variables are fixed for C++ targets only. |
BlazeCidrLauncher is aware of environment variables configured in run configuration window. So far it looks like no one just forwarded these variables down to executable process for some unknown reason. fixes bazelbuild#5770
ujohnny
force-pushed
the
enovozhilov/env-vars-to-bazel-run-debug
branch
from
8b5c0f8
to
1b0855f
Compare
tpasternak
approved these changes
Dec 11, 2023
github-actions
bot
removed
the
awaiting-review
3 tasks
mai93
reviewed
Dec 28, 2023
| @@ -234,11 +241,6 @@ public CidrDebugProcess createDebugProcess(CommandLineState state, XDebugSession | |||
| commandLine.addParameters(handlerState.getExeFlagsState().getFlagsForExternalProcesses()); | |||
| commandLine.addParameters(handlerState.getTestArgs()); | |||
|
|
|||
| EnvironmentVariablesData envState = handlerState.getEnvVarsState().getData(); | |||
There was a problem hiding this comment.
why is it no longer needed for the debug process?
There was a problem hiding this comment.
If I understand correctly, it's been moved to createProcess, which is called later in this method
There was a problem hiding this comment.
I think the call to createProcess is outside the if (!BlazeGDBServerProvider.shouldUseGdbserver()) which returns in line https://github.com/bazelbuild/intellij/pull/5771/files#diff-00e836fdd8bc72a7c8afc8a99218bf627c22fdde6649d55acefc02abe392b990R259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #5770, #2042
Description of this change
BlazeCidrLauncher is aware of environment variables configured in run configuration window.
So far it looks like no one just forwarded these variables down to executable process for some
unknown reason.
fixes #5770, fixes #2042