Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape regex-relevant characters in test filter #5745

Merged

Commits on Nov 21, 2023

  1. Escape regex-relevant characters in test filter

    Go tests can contain arbitrary characters because they're not tied to a
    symbol name in a source file. Accordingly, they may contain characters
    which have special meaning for regexes. Because the Go test runner
    interprets this flag as a regex, we need to escape these.
    
    Without this, running a single test from the gutter, Bazel will exit 0
    and look happy, but it won't have actually run the test (which perhaps
    would have failed if it had run).
    illicitonion committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0dfff01 View commit details
    Browse the repository at this point in the history