Fix the handling of the cc_headers inside build_dependencies.bzl to ensure it consistently uses a depset, rather than using a list in some cases and a depset in others.
#5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
copybara-exported
copybara-service
bot
force-pushed
the
test_578138061
branch
3 times, most recently
from
2fa3e02
to
378191e
Compare
copybara-service
bot
force-pushed
the
test_578138061
branch
from
378191e
to
f8c3614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the handling of the cc_headers inside
build_dependencies.bzlto ensure it consistently uses adepset, rather than using a list in some cases and adepsetin others.