-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed project to import wizard project view field #5227
Add managed project to import wizard project view field #5227
Conversation
In general, I'd love to make the "choose the project view file" better. However, I have a couple of high-level thoughts:
|
Thanks @blorente As for understanding the differences, thats a fair point, and I do agree updates to clearly this and the other options makes sense. I could add the path to the file as part of the option, but let me think about other options too. |
Yeah, imo it would be nice to move the new radio buttons to the bottom, and add textboxes presenting the paths (like under "Import project view file" radio button, but read-only) What do you think about it @blorente ? |
@tpasternak I agree with your points, moving the radio buttons to the bottom and explaining which file it is is probably sufficient. |
e2d5a7c
to
fc0ef82
Compare
Thank you @brian-mcnamara ! |
It could make the initial import a bit more convenient Following the change implemented in bazelbuild/intellij#5227 (comment), the IntelliJ plugin recognizes the "default" project view file. Closes #21969. PiperOrigin-RevId: 634394317 Change-Id: If4e4372e6489597c65c8127bfa0c508854674380
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Description of this change
This change adds either a default or adds to the history the projects .managed.bazelproject file if it exists. This helps users who are importing the project though the wizard to find this file