Skip to content

Commit

Permalink
Respect user settings for showing console windows on query sync
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 588906081
  • Loading branch information
Googler authored and copybara-github committed Dec 8, 2023
1 parent d58c32b commit c821b4d
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.idea.blaze.base.scope.scopes.ProblemsViewScope;
import com.google.idea.blaze.base.scope.scopes.ProgressIndicatorScope;
import com.google.idea.blaze.base.scope.scopes.ToolWindowScope;
import com.google.idea.blaze.base.settings.BlazeUserSettings;
import com.google.idea.blaze.base.settings.BlazeUserSettings.FocusBehavior;
import com.google.idea.blaze.base.sync.SyncMode;
import com.google.idea.blaze.base.sync.SyncResult;
Expand Down Expand Up @@ -296,6 +297,7 @@ private ListenableFuture<Boolean> createAndSubmitRunTask(
ThrowingScopedOperation operation,
TaskOrigin taskOrigin) {
querySyncActionStatsScope.getBuilder().setTaskOrigin(taskOrigin);
BlazeUserSettings userSettings = BlazeUserSettings.getInstance();
return ProgressiveTaskWithProgressIndicator.builder(project, title)
.submitTaskWithResult(
indicator ->
Expand All @@ -311,7 +313,7 @@ private ListenableFuture<Boolean> createAndSubmitRunTask(
? showWindowOnAutomaticSyncErrors.getValue()
? FocusBehavior.ON_ERROR
: FocusBehavior.NEVER
: FocusBehavior.ALWAYS)
: userSettings.getShowBlazeConsoleOnSync())
.setIssueParsers(
BlazeIssueParser.defaultIssueParsers(
project,
Expand All @@ -322,7 +324,9 @@ private ListenableFuture<Boolean> createAndSubmitRunTask(
.push(new ProgressIndicatorScope(indicator))
.push(scope)
.push(querySyncActionStatsScope)
.push(new ProblemsViewScope(project, FocusBehavior.ALWAYS))
.push(
new ProblemsViewScope(
project, userSettings.getShowProblemsViewOnSync()))
.push(new IdeaLogScope());
try {
operation.execute(context);
Expand Down

0 comments on commit c821b4d

Please sign in to comment.