Mitigate StartupActivity warnings

Since these startup activities do not require indexes we can make them DumbAware and the warning will not be shown. Advised path to migrate them to ProjectActivity is slightly challenging as it requires implementation of Kotlin suspend function in Java code and intellij has issues with bazel plugin indexing in this case. See https://youtrack.jetbrains.com/issue/IDEA-338613 for the details.
bazelbuild · Nov 22, 2023 · 7823d49 · 7823d49
1 parent 1535596
commit 7823d49
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 8 deletions.
diff --git a/base/src/com/google/idea/blaze/base/formatter/ExternalFormatterCodeStyleManager.java b/base/src/com/google/idea/blaze/base/formatter/ExternalFormatterCodeStyleManager.java
@@ -43,7 +43,7 @@
  */
 class ExternalFormatterCodeStyleManager extends DelegatingCodeStyleManager {
 
-  static class Installer implements StartupActivity {
+  static class Installer implements StartupActivity.DumbAware {
     @Override
     public void runActivity(Project project) {
       FormatterInstaller.replaceFormatter(project, ExternalFormatterCodeStyleManager::new);

diff --git a/base/src/com/google/idea/blaze/base/sync/BlazeSyncStartupActivity.java b/base/src/com/google/idea/blaze/base/sync/BlazeSyncStartupActivity.java
@@ -27,7 +27,7 @@
 import com.intellij.openapi.startup.StartupActivity;
 
 /** Syncs the project upon startup. */
-public class BlazeSyncStartupActivity implements StartupActivity {
+public class BlazeSyncStartupActivity implements StartupActivity.DumbAware {
 
   public static final String SYNC_REASON = "BlazeSyncStartupActivity";
 

diff --git a/clwb/src/com/google/idea/blaze/clwb/run/producers/NonBlazeProducerSuppressor.java b/clwb/src/com/google/idea/blaze/clwb/run/producers/NonBlazeProducerSuppressor.java
@@ -22,7 +22,7 @@
 import com.intellij.openapi.startup.StartupActivity;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   private static final ImmutableList<String> PRODUCERS_TO_SUPPRESS =
       ImmutableList.of(

diff --git a/golang/src/com/google/idea/blaze/golang/run/producers/NonBlazeProducerSuppressor.java b/golang/src/com/google/idea/blaze/golang/run/producers/NonBlazeProducerSuppressor.java
@@ -24,7 +24,7 @@
 import com.intellij.openapi.startup.StartupActivity;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   /**
    * Returns a list of run configuration producers to suppress for Blaze projects.

diff --git a/java/src/com/google/idea/blaze/java/run/producers/NonBlazeProducerSuppressor.java b/java/src/com/google/idea/blaze/java/run/producers/NonBlazeProducerSuppressor.java
@@ -22,7 +22,7 @@
 import com.intellij.openapi.startup.StartupActivity;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   private static final ImmutableList<String> KOTLIN_PRODUCERS =
       ImmutableList.of(

diff --git a/...script/src/com/google/idea/blaze/javascript/run/producers/NonBlazeProducerSuppressor.java b/...script/src/com/google/idea/blaze/javascript/run/producers/NonBlazeProducerSuppressor.java
@@ -34,7 +34,7 @@
 import java.util.stream.Collectors;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   /**
    * Returns a list of run configuration producers to suppress for Blaze projects.

diff --git a/python/src/com/google/idea/blaze/python/run/producers/NonBlazeProducerSuppressor.java b/python/src/com/google/idea/blaze/python/run/producers/NonBlazeProducerSuppressor.java
@@ -22,9 +22,10 @@
 import com.intellij.execution.actions.RunConfigurationProducer;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.startup.StartupActivity;
+import com.intellij.util.JavaCoroutines;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   // PyTestsConfigurationProducer has internal visibility. We need to reference it to suppress it.
   @SuppressWarnings("KotlinInternal")

diff --git a/scala/src/com/google/idea/blaze/scala/run/producers/NonBlazeProducerSuppressor.java b/scala/src/com/google/idea/blaze/scala/run/producers/NonBlazeProducerSuppressor.java
@@ -26,7 +26,7 @@
 import org.jetbrains.plugins.scala.testingSupport.test.specs2.Specs2ConfigurationProducer;
 
 /** Suppresses certain non-Blaze configuration producers in Blaze projects. */
-public class NonBlazeProducerSuppressor implements StartupActivity {
+public class NonBlazeProducerSuppressor implements StartupActivity.DumbAware {
 
   private static final ImmutableList<Class<? extends RunConfigurationProducer<?>>>
       // ImmutableList.of(...) is broken: https://youtrack.jetbrains.com/issue/SCL-14531