Remove --local_test_jobs from bazelci.py - #2867
Open
meteorcloudy wants to merge 1 commit into
Open
meteorcloudy wants to merge 1 commit into
meteorcloudy wants to merge 1 commit into
Conversation
Let Bazel use its default --local_test_jobs=auto (0) so that local test concurrency is managed by ResourceManager based on HOST_CPUS, HOST_RAM, test sizes, and cpu/resources tags instead of bypassing CPU/RAM accounting.
Member
Author
|
Also tested on Bazel via bazelbuild/bazel#31171 |
meisterT
approved these changes
Sep 17, 2026
Member
Author
|
Looks like this actually causing tests to be flaky on windows, I need to investigate more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
--local_test_jobsandconcurrent_test_jobs()fromexecute_bazel_testandexecute_bazel_coverageinbazelci.py.Why
--local_test_jobsis set to a non-zero value, Bazel'sTestTargetProperties.getLocalResourceUsage()assignscpu=0andmemory=0to all test actions (unless explicitly tagged withcpu:Norresources:...), ignoring test size memory estimates (small/medium/large/enormous) and allowing build + test actions to oversubscribe host CPUs during mixed compilation/test phases.c4a-standard-8):concurrent_jobssets--jobs=8(cpu_count()), whileconcurrent_test_jobshardcoded--local_test_jobs=12, causing Bazel to emit a warning on every test/coverage run (WARNING: High value for --local_test_jobs: 12. This exceeds the value for --jobs: 8.).c2-standard-30): Hardcoding--local_test_jobsto12on Linux and8on Windows left 60%–73% of CPU cores idle during pure test execution phases.--local_test_jobsin their.bazelci/presubmit.yml.