Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify the environment when executing a CI command #2116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 22, 2024

os.environ does not contain certain special environment variables on Windows (e.g. =C:) that are present when executing from cmd.exe.

`os.environ` does not contain certain special environment variables on Windows (e.g. `=C:`) that are present when executing from `cmd.exe`.
@meteorcloudy
Copy link
Member

We probably cannot remove this, because we do set a bunch of env vars to pass information to the Bazel binary:

https://github.com/search?q=repo%3Abazelbuild%2Fcontinuous-integration+os.environ+path%3A%2F%5Ebuildkite%5C%2Fbazelci.py%2F&type=code

@fmeum
Copy link
Contributor Author

fmeum commented Nov 22, 2024

But isn't the default to inherit the current process environment, which should be equivalent to passing os.environ except for filtering out these weird variables?

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 22, 2024

Ah, that's a good point. I'll test this in our testing buildkite org.

Another concern is that this might mess up bisecting on windows, since the --client_env will shadow other failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants