Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go vet as presubmit check #188

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

fweikert
Copy link
Member

This commit runs go vet with shadowing detection (among other checks) during presubmits in order to prevent variable shadowing, which caused #185.

Note: The shadowing check is no longer part of go vet by default, hence we need to run three commands instead of a single "go vet".

@philwo
Copy link
Member

philwo commented Oct 20, 2020

Just FYI, the Windows-presubmit passes now :)

@fweikert
Copy link
Member Author

Thanks! I still need to investigate why the "go vet" presubmit is NOT failing :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants