Conversation
Move aquery_differ and ctexplain to scripts/ and remove the unused Android instrumentation checker/platform, compliance experiment, defaults package, and test_rules.bzl. None is included in the embedded tools archive. Stop embedding the JDK BUILD templates, nosystemjdk README, C++ test data, Python wrapper template/test, and generated WORKSPACE stub. The embedded BUILD files do not expose the latter files as targets; exported BUILD metadata itself is not a supported consumer interface. Keep the JDK BUILD.java_tools* templates in the source repository for packaging. Remove the embedded import-deps-checker and jarhelper packages: the former requires the unavailable @android_tools repository, while the latter requires absent Bazel source packages. These targets cannot be analyzed from @bazel_tools. Keep their implementations in the source repository. Retain usable public labels and loadable Starlark files for the following commits, including the buildstamp example and build_rules utilities. Update source distributions, CI labels and moved Python imports together.
fmeum
marked this pull request as ready for review
September 16, 2026 09:12
fmeum
requested review from
Wyverald and
meteorcloudy
and removed request for
ahumesky and
ted-xie
September 16, 2026 09:12
github-actions
Bot
added
team-Android
fmeum
changed the title
tools/
Member
|
This probably needs some massage during importing. @Wyverald is working on cleaning up MODULE.tools, so I will wait for him to review and the other PR. |
Member
|
Enthusiastic LGTM from my side! I leave it to Xudong to decide how this should be imported (e.g. do we want to split it up?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unused repository tooling and files that do not provide usable targets in
@bazel_tools:aquery_differandctexplainfromtools/toscripts/, updating Python imports, usage examples, CI targets and source-distribution entries. Neither tool is embedded in@bazel_tools.tools/defaultspackage and obsoletetest_rules.bzl; these are not embedded either.nosystemjdk/README, C++ test data, Python wrapper template/test and generated WORKSPACE stub. Retain the JDK BUILD templates in the source repository for Java-tools packaging.@android_toolsrepository, and the latter requires absent Bazel source packages, so their embedded targets cannot be analyzed. Their implementations remain in the source repository.Motivation
This is the almost fully safe part of the tools cleanup since these files were either not embedded at all, broken, or only reachable via explicit repo rule
rctx.pathusage, which is out of scope.Slightly more risky but still reasonably safe removals will be done in a follow-up PR.
Build API Changes
Checklist
Release Notes
RELNOTES: None