Skip to content

Flip incompatible_strict_action_env #26587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Flip incompatible_strict_action_env #26587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879fa81
Flip incompatible_strict_action_env
hofbi Jul 21, 2025
fe4238b
Forward path
hofbi Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public static class StrictActionEnvOptions extends FragmentOptions {
@Option(
name = "incompatible_strict_action_env",
oldName = "experimental_strict_action_env",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,8 +741,7 @@ public RemoteOutputsStrategyConverter() {
+ " affected actions.\n\n"
+ "In order to successfully use this feature, you likely want to set a custom"
+ " --host_platform together with --experimental_platform_in_output_dir (to normalize"
+ " output prefixes) and --incompatible_strict_action_env (to normalize environment"
+ " variables).")
+ " output prefixes).")
public Scrubber scrubber;

@Option(
Expand Down
2 changes: 1 addition & 1 deletion src/test/shell/bazel/bazel_test_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ EOF

# With --action_env=PATH, the local PATH is forwarded to the test.
PATH=$PATH:$PWD/scripts bazel test //testing:t1 -s --run_under=hello \
--test_output=all >& $TEST_log || fail "Expected success"
--test_output=all --action_env=PATH >& $TEST_log || fail "Expected success"
expect_log 'hello script!!! testing/t1'

# We need to forward the PATH to make it work.
Expand Down
2 changes: 1 addition & 1 deletion src/test/shell/bazel/starlark_repository_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2843,7 +2843,7 @@ EOF

repo_cache_dir=$TEST_TMPDIR/repository_cache
trap 'rm -rf ${repo_cache_dir}' EXIT
bazel build --repository_cache="$repo_cache_dir" \
bazel build --repository_cache="$repo_cache_dir" --action_env=PATH \
//:unique_hashes >& $TEST_log || fail "expected bazel to succeed"
assert_equals 1 "$(wc -l < bazel-bin/unique_hashes | tr -d ' ')"
assert_equals $sha "$(cat bazel-bin/unique_hashes)"
Expand Down