Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LoongArch64 #23965

Closed
wants to merge 1 commit into from
Closed

Support LoongArch64 #23965

wants to merge 1 commit into from

Conversation

zunley
Copy link

@zunley zunley commented Oct 14, 2024

@zunley zunley requested a review from a team as a code owner October 14, 2024 06:40
@zunley zunley requested review from aranguyen and removed request for a team October 14, 2024 06:40
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Oct 14, 2024
@zunley
Copy link
Author

zunley commented Oct 14, 2024

Depends on bazelbuild/platforms#106

@katre
Copy link
Member

katre commented Oct 14, 2024

Why does this need to be in Bazel? Defining the constraint and platform in tensorflow should be sufficient without any Bazel or platforms changes.

@zunley
Copy link
Author

zunley commented Oct 15, 2024

Why does this need to be in Bazel?

@katre I hope that bazel can support it natively and widely, which is more friendly for building projects such as kubernetes and envoy on loongarch64, which is why I added support for rules_go bazel-contrib/rules_go#4142.

@katre
Copy link
Member

katre commented Oct 15, 2024

Bazel does not need to support this natively, defining a custom constraint_value with your own platform and toolchain definitions (in your project) will be sufficient.

@katre katre closed this Oct 15, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants