[7.4.0] Add conlyopts and cxxopts attributes to cc rules #23904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inability to pass C or C++ specific compiler flags to targets that contain a mix of those sources is a common sticking point for new users. These mirror the global `--conlyopt` and `--cxxopt` flags but at the target level. Fixes bazelbuild#22041 RELNOTES: Add conlyopts and cxxopts attributes to cc rules Closes bazelbuild#23840 PiperOrigin-RevId: 682144094 Change-Id: I0fe8b728c493652d875ce6a6dd2a9989c36b1f24 (cherry picked from commit 5854788)
github-actions
bot
added
awaiting-review
comius
approved these changes
Oct 9, 2024
|
@keith Does this PR add the attributes to |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No. At head the logic for that is a bit different so I have touched it |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inability to pass C or C++ specific compiler flags to targets that
contain a mix of those sources is a common sticking point for new users.
These mirror the global
--conlyoptand--cxxoptflags but at thetarget level.
Fixes #22041
RELNOTES: Add conlyopts and cxxopts attributes to cc rules
Closes #23840
PiperOrigin-RevId: 682144094
Change-Id: I0fe8b728c493652d875ce6a6dd2a9989c36b1f24
(cherry picked from commit 5854788)