Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --cxxopt apply to ObjC++ files #23858

Closed
wants to merge 1 commit into from
Closed

Make --cxxopt apply to ObjC++ files #23858

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Oct 3, 2024

Fixes #12716

@keith keith requested a review from lberki as a code owner October 3, 2024 04:53
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 3, 2024
@keith keith mentioned this pull request Oct 3, 2024
Closed
@lberki lberki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 7, 2024
@iancha1992
Copy link
Member

@lberki looks like one of the tests is failing?

@keith
Copy link
Member Author

keith commented Oct 7, 2024

looks like a flaky download

@copybara-service copybara-service bot closed this in 6e9de20 Oct 7, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 7, 2024
@keith keith deleted the ks/make-cxxopt-apply-to-objc-files branch October 7, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

objc_library does not use the right C++ dialect when compiling .mm files
3 participants
@keith @iancha1992 @lberki