Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cancel repository downloads #23837

Closed
wants to merge 7 commits into from
Closed

Properly cancel repository downloads #23837

wants to merge 7 commits into from
+65 −7

Commits on Oct 10, 2024

  1. Properly await repository downloads cancellations 

    When cancelling an asynchronous repository download task, an interrupt
signal is sent to the download thread. This doesn't mean that the
download stops immediately. Avoid restarting a download until the
previous download has actually stopped, so that the new download is able
to clean old data without crashing (on Windows).

Fixes bazelbuild#21773
    @moroten
    moroten committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    441c6b1 View commit details
    Browse the repository at this point in the history

  2. Await termination in PendingDownload#close

    @fmeum @moroten
    fmeum authored and moroten committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1b42adc View commit details
    Browse the repository at this point in the history

  3. Fix HttpDownloaderTest

    @moroten
    moroten committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e634f92 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Fix documentation and @OverRide

    @moroten
    moroten committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3b21485 View commit details
    Browse the repository at this point in the history

  2. countDown doneSignal even if downloader task doesn't start

    @moroten
    moroten committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    54ff036 View commit details
    Browse the repository at this point in the history

  3. Swap CountDownLatch for Phaser

    @moroten
    moroten committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8949c98 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Use phase=0 as download phase instead of looking for a terminated Phaser

    @moroten
    moroten committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f9cbea5 View commit details
    Browse the repository at this point in the history