Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Fix runtime_solib_name for --incompatible_macos_set_install_name #23672

Merged
merged 1 commit into from
Sep 23, 2024

Commits on Sep 19, 2024

  1. Fix runtime_solib_name for --incompatible_macos_set_install_name

    The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect.
    
    This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.
    
    Work towards bazelbuild#12370
    
    Closes bazelbuild#23089.
    
    PiperOrigin-RevId: 668228562
    Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99
    fmeum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e489984 View commit details
    Browse the repository at this point in the history