[7.4.0] Convert values to Starlark values when concating string_list_dict type #23603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert values to Starlark values when concating string_list_dict type. This is because Dict checks that all the values put in it are Starlark valid values. But string_list_dict value is of type List<String>, when Java's List isn't a Starlark value. Fixes bazelbuild#23065 My first PR to bazel 🤩 Would love you to review the PR. Checked that the test didn't pass before the change and did after it. Closes bazelbuild#23424. PiperOrigin-RevId: 673463108 Change-Id: Ib2cdce7d94243f4e3bda23203a196fee4e766189
bazel-io
added
team-Starlark-Interpreter
com.google.devtools.build.lib.packages.Types was introduced in master branch by commit 35fb4dd
tetromino
approved these changes
Sep 11, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 11, 2024
71e2578
50 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert values to Starlark values when concating string_list_dict type.
This is because Dict checks that all the values put in it are Starlark valid values. But string_list_dict value is of type List, when Java's List isn't a Starlark value.
Fixes #23065
My first PR to bazel 🤩 Would love you to review the PR.
Checked that the test didn't pass before the change and did after it.
Closes #23424.
PiperOrigin-RevId: 673463108
Change-Id: Ib2cdce7d94243f4e3bda23203a196fee4e766189
Commit f1f8d58