[7.4.0] Fix cache duration computation in CredentialCacheExpiry. #23453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the supplied current time instead of calling Instant.now(). I don't know how to meaningfully test this; there's so little going on that the test would essentially mirror the implementation. Fixes bazelbuild#23429. PiperOrigin-RevId: 668351088 Change-Id: I12f1575e5280330c61361e4cf1b7d9f9231f16eb
bazel-io
added
team-Remote-Exec
tjgq
approved these changes
Aug 28, 2024
tjgq
approved these changes
Aug 28, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Aug 28, 2024
6980120
52 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the supplied current time instead of calling Instant.now().
I don't know how to meaningfully test this; there's so little going on that the test would essentially mirror the implementation.
Fixes #23429.
PiperOrigin-RevId: 668351088
Change-Id: I12f1575e5280330c61361e4cf1b7d9f9231f16eb
Commit 5209ce7