Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bazel 7.3.1 and flip --incompatible_use_plus_in_repo_names #23450

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
common --enable_platform_specific_config
common --incompatible_use_plus_in_repo_names

# Shared configuration flags to build and test Bazel on RBE.
build:remote_shared --remote_instance_name=projects/bazel-untrusted/instances/default_instance
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.3.0
7.3.1
6 changes: 2 additions & 4 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,8 @@ pkg_tar(
srcs = ["@maven//:srcs"] + ["MAVEN_CANONICAL_REPO_NAME"],
package_dir = "derived/maven",
remap_paths = {
# We need the repo names according to "builder bazel" (instead of "bazel being built") here.
# Remove the `replace` parts after building with 7.3.0.
"external/" + get_canonical_repo_name("@maven").replace("+", "~") + "/": "",
"../" + get_canonical_repo_name("@maven").replace("+", "~") + "/": "",
"external/" + get_canonical_repo_name("@maven") + "/": "",
"../" + get_canonical_repo_name("@maven") + "/": "",
},
strip_prefix = ".",
visibility = ["//:__subpackages__"],
Expand Down
8 changes: 7 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ single_version_override(
],
)

single_version_override(
module_name = "protobuf",
patch_strip = 1,
patches = ["//third_party:protobuf_21.7.patch"],
)

# The following Bazel modules are not direct dependencies for building Bazel,
# but are required for visibility from DIST_ARCHIVE_REPOS in repositories.bzl
bazel_dep(name = "apple_support", version = "1.8.1")
Expand Down Expand Up @@ -356,9 +362,9 @@ bazel_dep(name = "bazel_ci_rules", version = "1.0.0")
bazel_test_deps = use_extension("//:extensions.bzl", "bazel_test_deps")
use_repo(
bazel_test_deps,
"kythe_release",
"local_bazel_source_list",
"local_config_winsdk",
"kythe_release",
)

bazel_rbe_deps = use_extension("//:rbe_extension.bzl", "bazel_rbe_deps")
Expand Down
Loading
Loading