Handle invalid base64 in SRI #23410
Closed
Handle invalid base64 in SRI #23410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
fmeum
approved these changes
Aug 23, 2024
| try { | ||
| return Base64.getDecoder().decode(data); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new InvalidChecksumException("Invalid base64 " + data, e); |
There was a problem hiding this comment.
Suggested change
| throw new InvalidChecksumException("Invalid base64 " + data, e); | |
| throw new InvalidChecksumException("Invalid base64: " + data, e); |
Clarifies where the invalid base64 starts as it might be very invalid.
There was a problem hiding this comment.
I will put the value in quotes since that's what the other error messages in this file do.
Previously, invalid base64 would crash the Bazel server.
benjaminp
force-pushed
the
checksum-invalid-base64
branch
from
ccf0907
to
3322d6d
Compare
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Aug 26, 2024
Previously, invalid base64 would crash the Bazel server. Closes bazelbuild#23410. PiperOrigin-RevId: 667624565 Change-Id: I7b6b834fd291e9a3dae59df88b29bb378e7663a3
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Previously, invalid base64 would crash the Bazel server. Closes #23410. PiperOrigin-RevId: 667624565 Change-Id: I7b6b834fd291e9a3dae59df88b29bb378e7663a3 Commit 1b0ed28 --------- Co-authored-by: Benjamin Peterson <[email protected]> Co-authored-by: Yun Peng <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, invalid base64 would crash the Bazel server.