-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let repo rule attributes reference extension apparent names #23369
Conversation
94bd2b6
to
39dde25
Compare
39dde25
to
f583cca
Compare
This is currently stacked on #23371. |
426d02b
to
7b674cd
Compare
I fixed up the error messages and also rebased on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks nice!
*/ | ||
public ImmutableMap<String, RepoSpec> createAndGetRepos(StarlarkSemantics starlarkSemantics) | ||
throws EvalException, InterruptedException { | ||
// LINT.IfChange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually work? I'm wondering if this plays well with copybara.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what copybara does with it in the GitHub -> google3 direction, but Ivo has been adding a bunch of these comments lately, so I would expect them to work at least if you fix them up during import.
bazel/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java
Lines 759 to 761 in d5434b3
// LINT.ThenChange(//src/main/starlark/builtins_bzl/common/cc/link/lto_indexing_action.bzl) | |
// LINT.IfChange |
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
moduleExtensionMetadata, | ||
repoMappingRecorder.recordedEntries()); | ||
} catch (EvalException e) { | ||
env.getListener().handle(Event.error(e.getMessageWithStack())); | ||
Location innermostLocation = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a common pattern? IOW why don't we do this with other catch (EvalException e)
clauses? If we should, should we create a helper method for it or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a helper method and updated all other cases I could find. It's slightly duplicative information as the stack trace also contains locations, but this gets rid of the <builtin>
and is also easier to parse and copy-paste.
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
@bazel-io fork 7.4.0 |
…23585) Fixes #19055 RELNOTES: Repository rules instantiated in the same module extensions can now refer to each other by their extension-specified names in label attributes. Closes #23369. PiperOrigin-RevId: 666893202 Change-Id: Ib2eaa55fcb563adc86e16dc4a357ac808228ebda --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
Fixes #19055
RELNOTES: Repository rules instantiated in the same module extensions can now refer to each other by their extension-specified names in label attributes.