[7.4.0] Add path mapping support for C++ compile action templates #23349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ action templates are now properly path mapped. Since the default Unix toolchain doesn't support object file groups on macOS, `apple_support` is needed in the test. This requires wiring up `LocalEnvProvider` in the remote worker to get `DEVELOPER_DIR` to be set, which in turn requires improving the runfiles handling for the the worker. Work towards bazelbuild#6526 Closes bazelbuild#22890. PiperOrigin-RevId: 657733074 Change-Id: I132e338d7a44964a8a1aad3062a5c9a4c8e79e57
iancha1992
added
team-Rules-CPP
comius
approved these changes
Aug 26, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Aug 26, 2024
20582e6
53 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ action templates are now properly path mapped.
Since the default Unix toolchain doesn't support object file groups on macOS,
apple_supportis needed in the test. This requires wiring upLocalEnvProviderin the remote worker to getDEVELOPER_DIRto be set, which in turn requires improving the runfiles handling for the the worker.Work towards #6526
Closes #22890.
PiperOrigin-RevId: 657733074
Change-Id: I132e338d7a44964a8a1aad3062a5c9a4c8e79e57
Commit 23f3be0