WIP: Don't overwrite jdeps #23313
Closed
WIP: Don't overwrite jdeps #23313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes failures such as the following when a spawn, e.g. a reduced Java compilation spawn, doesn't create an optional output:
```
java.io.FileNotFoundException: /private/var/tmp/_bazel_fmeum/507738cfc7e6cde00e4a0230e9aa0722/execroot/_main/bazel-out/_tmp/actions/remote/175.tmp (No such file or directory)
at com.google.devtools.build.lib.unix.NativePosixFiles.lstat(Native Method)
at com.google.devtools.build.lib.unix.UnixFileSystem.statInternal(UnixFileSystem.java:212)
at com.google.devtools.build.lib.unix.UnixFileSystem.stat(UnixFileSystem.java:201)
at com.google.devtools.build.lib.vfs.Path.stat(Path.java:290)
at com.google.devtools.build.lib.vfs.FileSystemUtils.moveFile(FileSystemUtils.java:456)
at com.google.devtools.build.lib.remote.RemoteExecutionService.moveOutputsToFinalLocation(RemoteExecutionService.java:878)
...
```
Also clean up temporary files in case of an exception.
fmeum
force-pushed
the
dont-overwrite-jdeps
branch
2 times, most recently
from
d784457
to
f6c0d31
Compare
fmeum
force-pushed
the
dont-overwrite-jdeps
branch
from
f6c0d31
to
9f7aaf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #23288