Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coverage] Parsing file log level to DEBUG #20880

Closed
wants to merge 1 commit into from

Conversation

mortenmj
Copy link

#17499 was closed as stale. This logging is still very noisy, so it would be great to get this merged.

Fixes #17492

@mortenmj mortenmj requested a review from lberki as a code owner January 12, 2024 19:03
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 12, 2024
@mortenmj
Copy link
Author

mortenmj commented Jan 12, 2024

CI is failing; I guess Level.Debug doesn't exist. What would be reasonable here? Does this need to be logged at all?

@sgowroji sgowroji added team-Rules-Server Issues for serverside rules included with Bazel awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 16, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jan 31, 2024

CI is failing; I guess Level.Debug doesn't exist. What would be reasonable here? Does this need to be logged at all?

This is a standalone Java program, not part of the Bazel server. We can't just inherit the same logging settings, so we'll have to come up with some other setting to gate this behind.

@c-mita Is the output used at Google?

@fmeum fmeum added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Jan 31, 2024
@c-mita c-mita self-assigned this Feb 21, 2024
@mortenmj
Copy link
Author

@c-mita if you'd like to make changes to this PR, please feel free

@c-mita
Copy link
Member

c-mita commented Feb 22, 2024

Looking at https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/util/logging/Level.html - it looks like the "correct" setting would be Level.FINE?

But the issue is that I don't actually know if, when Bazel runs this program, if the desired log level can be specified. I don't want to lose the ability to see these messages because they can be helpful when there are problems with the coverage output, but I appreciate that they can generate a lot of noise in some cases. I suspect we'll have to wire in a configuration switch somewhere.

@mortenmj
Copy link
Author

Fixed by #22257

@mortenmj mortenmj closed this May 26, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseFilesSequentially log spew with large number of coverage enabled Bazel targets
4 participants