Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid some //external:android uses #19575

Closed

Conversation

keith
Copy link
Member

@keith keith commented Sep 20, 2023

This is a hack to show the kind of things that needs to be done to make rules_android bzlmod compatible. In general we have to remove all uses to //external:android

This can be tested with bazelbuild/rules_android#148

This is a hack to show the kind of things that needs to be done to make
rules_android bzlmod compatible. In general we have to remove all
uses to `//external:android`
@keith keith marked this pull request as ready for review September 20, 2023 21:08
@keith keith marked this pull request as draft September 20, 2023 21:08
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Android Issues for Android team labels Sep 20, 2023
@keith keith closed this Feb 29, 2024
@keith keith deleted the ks/avoid-some-external-android-uses branch February 29, 2024 17:04
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant