Add blake3 NEON instructions on linux arm64 #19384
Conversation
otherwise getting libunix_jni.so: undefined symbol: blake3_hash_many_neon see bazelbuild@d0de5e0
github-actions
bot
added
the
awaiting-review
third_party/blake3/blake3.BUILD
Outdated
| "@bazel_tools//src/conditions:linux_aarch64": [ | ||
| "-DBLAKE3_USE_NEON=0", | ||
| ], |
There was a problem hiding this comment.
Shouldn't we instead include c/blake3_neon.c like we do in the @bazel_tools//src/conditions:darwin_arm64 condition above, and set -DBLAKE3_USE_NEON=1? Same for windows arm64 @meteorcloudy.
There was a problem hiding this comment.
Yeah that works, I can make the change for windows here as well, but I'll wait for @meteorcloudy comments.
There was a problem hiding this comment.
LGTM, /cc @tylerwilliams who made the blake3 contribution in #18682
There was a problem hiding this comment.
Tyler gave me the tip. I think we should do the Windows path as well.
There was a problem hiding this comment.
Yeah this change looks good to me too
mauriciogg
changed the title
iancha1992
added
the
team-Remote-Exec
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
Can you please also sync the blake3 BUILD file change to https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/blake3 ? |
|
You can have a new version named |
|
Context: I'm working on #19087, so in future, blake3 will come from the BCR. |
otherwise getting libunix_jni.so: undefined symbol: blake3_hash_many_neon see bazelbuild@d0de5e0 Closes bazelbuild#19384. PiperOrigin-RevId: 562479599 Change-Id: I8f0ca6b68486f5ea8db698f3f99526eb1c0de8a8
otherwise getting libunix_jni.so: undefined symbol: blake3_hash_many_neon see d0de5e0 Closes #19384. Commit 31812fe PiperOrigin-RevId: 562479599 Change-Id: I8f0ca6b68486f5ea8db698f3f99526eb1c0de8a8 Co-authored-by: Mauricio G <[email protected]>
otherwise getting libunix_jni.so: undefined symbol: blake3_hash_many_neon
see d0de5e0