Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.4.0] Add additional_linker_inputs option to cc_library rule #19264

Merged
merged 3 commits into from
Aug 22, 2023

Commits on Aug 16, 2023

  1. Add additional_linker_inputs option to cc_library rule

    This is achieved by the following related changes:
    
    1) Moving the `additional_linker_inputs` attribute up from the `cc_binary_base` rule to the `cc_rule`. The rationale here is that any rule that allows `linkopts` to be set should also support `additional_linker_inputs`.
    
    2) Adding the `additional_linker_inputs` attr to the `cc_library` rule context. This was copied verbatim from the existing `cc_binary` attribute list.
    
    3) Appending the `ctx.files.additional_linker_inputs` list to the list of linker scripts wherever they are passed as `additional_inputs` in the `cc_library.bzl` builtin file corresponding to the `cc_library` rule.
    
    ----------------------
    
    For context on this PR, see issue bazelbuild#17788 as well as the original [Google group discussion](https://groups.google.com/g/bazel-discuss/c/1VFvNBDqzVU/m/F5UmYO-RAAAJ), which inspired the feature request.
    
    Resolves bazelbuild#17788.
    
    Closes bazelbuild#18952.
    
    PiperOrigin-RevId: 557505297
    Change-Id: I4811b60e102c6426697efcb202296fe77a3d5f25
    nicholasjng authored and iancha1992 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    86d095a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    81c4158 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    014f91e View commit details
    Browse the repository at this point in the history