Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rerun module extensions when only imports or locations change #19253

Closed
wants to merge 2 commits into from
Closed

Do not rerun module extensions when only imports or locations change #19253

wants to merge 2 commits into from

Commits on Aug 15, 2023

  1. Do not rerun module extensions when only imports or locations change 

    When using the lockfile, extension evaluation results are now persisted
even if the imports (`use_repo`s) fail validation against the actually
generated repos and reused if only imports or Starlark locations change.

This requires storing `ModuleExtensionMetadata` in the lockfile to
ensure that the correct fixup warnings are shown if imports are updated
but the extension isn't rerun.
    @fmeum
    fmeum committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d43b4bd View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Address review comments

    @fmeum
    fmeum committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1614884 View commit details
    Browse the repository at this point in the history