Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the full absolute paths of runfiles in action keys #19171

Closed
wants to merge 2 commits into from
Closed

Include the full absolute paths of runfiles in action keys #19171

wants to merge 2 commits into from

Commits on Aug 17, 2023

  1. Include the full absolute paths of runfiles in action keys 

    Both `SourceManifestAction` and `SymlinkTreeAction`, the only users of
`Runfiles#fingerprint`, emit absolute paths to runfiles artifacts in
their output. This requires also including these paths in the action key
computation to prevent incorrect incremental builds if `--output_base`
changes.
    @fmeum
    fmeum committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ec30828 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @fmeum
    fmeum committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6114338 View commit details
    Browse the repository at this point in the history