Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark isolated extension usages as experimental #19021

Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 22, 2023

The isolate parameter of use_extension and the is_isolated field on module_ctx are only available with the --experimental_isolated_extension_usages flag.

@fmeum fmeum force-pushed the experimental_isolated_extension_usages branch 4 times, most recently from d4ec814 to 41dff98 Compare July 23, 2023 14:11
@fmeum fmeum force-pushed the experimental_isolated_extension_usages branch from 41dff98 to 9c426a1 Compare July 23, 2023 14:22
@fmeum fmeum marked this pull request as ready for review July 23, 2023 14:58
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jul 23, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 24, 2023
@Wyverald
Copy link
Member

@bazel-io fork 6.3.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 24, 2023
Wyverald pushed a commit that referenced this pull request Jul 24, 2023
The `isolate` parameter of `use_extension` and the `is_isolated` field on `module_ctx` are only available with the `--experimental_isolated_extension_usages` flag.

Closes #19021.

PiperOrigin-RevId: 550582124
Change-Id: I7486a3b344ca9d29614c26044f1943bfedfcc654
keertk pushed a commit that referenced this pull request Jul 24, 2023
The `isolate` parameter of `use_extension` and the `is_isolated` field on `module_ctx` are only available with the `--experimental_isolated_extension_usages` flag.

Closes #19021.

PiperOrigin-RevId: 550582124
Change-Id: I7486a3b344ca9d29614c26044f1943bfedfcc654

Co-authored-by: Fabian Meumertzheim <[email protected]>
@fmeum fmeum deleted the experimental_isolated_extension_usages branch July 24, 2023 18:01
@keertk
Copy link
Member

keertk commented Jul 25, 2023

@bazel-io fork 6.3.1

keertk added a commit that referenced this pull request Jul 25, 2023
The `isolate` parameter of `use_extension` and the `is_isolated` field on `module_ctx` are only available with the `--experimental_isolated_extension_usages` flag.

Closes #19021.

PiperOrigin-RevId: 550582124
Change-Id: I7486a3b344ca9d29614c26044f1943bfedfcc654

Co-authored-by: Fabian Meumertzheim <[email protected]>
@keertk
Copy link
Member

keertk commented Jul 25, 2023

@bazel-io fork 6.4.0

keertk added a commit that referenced this pull request Jul 25, 2023
The `isolate` parameter of `use_extension` and the `is_isolated` field on `module_ctx` are only available with the `--experimental_isolated_extension_usages` flag.

Closes #19021.

PiperOrigin-RevId: 550582124
Change-Id: I7486a3b344ca9d29614c26044f1943bfedfcc654

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants