Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional_linker_inputs option to cc_library rule #18952

Closed
wants to merge 1 commit into from
Closed

Add additional_linker_inputs option to cc_library rule #18952

wants to merge 1 commit into from

Commits on Jul 27, 2023

  1. feat: Add additional_linker_inputs option to cc_library rule

    This is achieved by the following related changes:
    
    1) Moving the `additional_linker_inputs` attribute up from the `cc_binary_base`
    rule to the `cc_rule`. The rationale here is that any rule that allows `linkopts`
    to be set should also support `additional_linker_inputs`.
    
    2) Adding the `additional_linker_inputs` attr to the `cc_library` rule context.
    This was copied verbatim from the existing `cc_binary` attribute list.
    
    3) Appending the `ctx.files.additional_linker_inputs` list to the list of
    linker scripts wherever they are passed as `additional_inputs` in the `cc_library.bzl`
    builtin file corresponding to the `cc_library` rule.
    nicholasjng committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    08ab105 View commit details
    Browse the repository at this point in the history