Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Versions < 7.0: Unsupported Resource Type "Macro" in "com.google.android.material:material:1.7.0" #18946

Conversation

EdbertChan
Copy link

Addresses: #17345

This is a bit of a hack. The jars were modified with Recaf to add the "macro" enum and recognize it when compiling material from upstream.

Line added in question: https://imgur.com/a/Rr2jvxZ

The more proper way is to take the source code of material, add the line, and then recompile and upload it to Bazel binary. This pull request just exists to unblock efforts.

However, should it be done the proper way, it should yield the same result and the binary will probably not change.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 14, 2023
@EdbertChan
Copy link
Author

Per my comment in the original issue:

It looks like this will be fixed and addressed in "com.android.tools.layoutlib:layoutlib-api:30.1.3"

However, it was introduced in this commit which is only available in 7.0
aaf94c6

Either this should be backported or the 7.0 timeline should be escalated.

I have opened up a pull request for people who are still on < 7.0 and need to be unblocked. However, note that this packaged layoutlib will be deleted eventually.

@EdbertChan EdbertChan changed the title Unsupported Resource Type "Macro" in "com.google.android.material:material:1.7.0" For Versions < 7.0: Unsupported Resource Type "Macro" in "com.google.android.material:material:1.7.0" Jul 14, 2023
@EdbertChan EdbertChan closed this Jul 14, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant