Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXPERIMENT - Use LLVM env vars in collect_cc_coverage #18903

Closed
wants to merge 2 commits into from
Closed

EXPERIMENT - Use LLVM env vars in collect_cc_coverage #18903

wants to merge 2 commits into from

Commits on Jul 11, 2023

  1. Extract coverage test helper functions into a separate shell script. 

    Removes a lot of the duplication across different coverage shell tests,
which all want similar functions.
    @c-mita
    c-mita committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    fc95f68 View commit details
    Browse the repository at this point in the history

  2. Use LLVM_COV and LLVM_PROFDATA variables over COVERAGE_GCOV_PATH 

    They are provided by the C++ rules and make it clearer what tool is
what. Also changes the C++ LLVM coverage test to specify GCOV as
llvm-cov, since that is the analogous tool and better represents how a
LLVM based tool chain might be configured.
    @c-mita
    c-mita committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c898e1d View commit details
    Browse the repository at this point in the history