Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract coverage test helper functions into a separate shell script. #18898

Closed
wants to merge 1 commit into from

Conversation

c-mita
Copy link
Member

@c-mita c-mita commented Jul 11, 2023

Removes a lot of the duplication across different coverage shell tests, which all want similar functions.

@c-mita c-mita requested a review from meisterT July 11, 2023 14:24
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 11, 2023
@c-mita
Copy link
Member Author

c-mita commented Jul 11, 2023

This also removes the check to disable tests if LLVM's gcov tool is used (since we use the same version check as the collect_cc_coverage.sh script).

In theory, these tests should be supported, although our test platform doesn't run them AFAIK.

@sgowroji sgowroji added coverage team-Rules-Server Issues for serverside rules included with Bazel labels Jul 11, 2023
@c-mita
Copy link
Member Author

c-mita commented Jul 11, 2023

This also removes the check to disable tests if LLVM's gcov tool is used (since we use the same version check as the collect_cc_coverage.sh script).

In theory, these tests should be supported, although our test platform doesn't run them AFAIK.

I've restored the check against llvm-cov; there seems to be an issue with Mac test runs, and the LLVM paths in collect_cc_coverage are a little confusing. I think the wrong tool is being used in the wrong situation, and I need to investigate more.

Removes a lot of the duplication across different coverage shell tests,
which all want similar functions.
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants