Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionCacheStatistics to BEP #17615

Closed

Conversation

crydell-ericsson
Copy link
Contributor

Solves #17315 .

The field action_cache_statistics has been added to the ActionSummary message of the BuildMetrics message in the build event protocol. This field is defined with the already-existing ActionCacheStatistics message and is set in the MetricsCollector when the action cache is saved.

The field action_cache_statistics has been
added to the ActionSummary message of the
BuildMetrics message in the build event
protocol. This field is defined with the
already-existing ActionCacheStatistics
message and is set in the MetricsCollector
when the action cache is saved.
@sgowroji sgowroji added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc awaiting-review PR is awaiting review from an assigned reviewer labels Feb 28, 2023
@haxorz haxorz requested a review from michaeledgar March 9, 2023 15:17
@brentleyjones
Copy link
Contributor

@bazelbuild/triage Can we get someone to review this please?

@crydell-ericsson
Copy link
Contributor Author

Are there any updates on the review of this PR?

@brentleyjones
Copy link
Contributor

@bazelbuild/triage @michaeledgar Can we get a review, or assigned to someone else, please? Thanks.

@haxorz haxorz added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 10, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 11, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 11, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 11, 2023
@iancha1992
Copy link
Member

@brentleyjones @haxorz @crydell-ericsson
I'm trying to cherry-pick this to release-6.3.0, but there are some conflicts.

  1. src/main/java/com/google/devtools/build/lib/buildeventstream/proto/BUILD
    "//src/main/java/com/google/devtools/build/lib/packages/metrics:package_load_metrics_proto" is missing as a dependency for "build_event_stream_proto". May need another commit that adds this to the file.

  2. src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
    "import "src/main/java/com/google/devtools/build/lib/packages/metrics/package_load_metrics.proto" is missing. May need another commit that adds this import.

  3. src/main/java/com/google/devtools/build/lib/metrics/BUILD
    For "metrics_module", it is missing "//third_party:auto_value" as one of its dependencies. May need another commit that adds this.

cc: @bazelbuild/triage

@brentleyjones
Copy link
Contributor

I'll leave it to @crydell-ericsson on how easy it is to get the dependent commits in, or if this can only really work with 7.0. The change looked small enough, so I was hopeful.

@crydell-ericsson
Copy link
Contributor Author

All of the differences mentioned by @iancha1992 are changes that have ended up being added while keeping this PR up to date with the master branch (perhaps that's something I shouldn't have done?). If you look at the initial commit in this PR 5f68c8f, you'll see that it does not have any of these dependencies.

In other words, the listed dependencies are not needed for the commit, they just happened to cause conflicts by being right next to the dependencies that were needed. Should I do anything from my side to amend this?

@brentleyjones
Copy link
Contributor

I think you can submit the cherry-pick PR (based on your original commit maybe?) and @iancha1992 would accept that.

@crydell-ericsson
Copy link
Contributor Author

I have put up a cherry pick PR in #18914 now. I haven't submitted PRs for cherry picks before, let me know if I've done anything incorrectly and I'll try to fix it.

@haxorz
Copy link
Contributor

haxorz commented Jul 12, 2023

I approved. The diff looked fine.

I've never authored or reviewed a cherrypick before, so someone else should probably double-check.

sluongng added a commit to buildbuddy-io/buildbuddy that referenced this pull request Oct 27, 2023
These proto files are taken from commit
bazelbuild/bazel@76117b4

Highlight:

- Inclusion of ActionCacheStatistics in build_event_stream
  bazelbuild/bazel#17615

- Explicit Execution phase timing (in prepare for Skymeld)
  bazelbuild/bazel@be63eee

- If `--noallow_analysis_cache_discard` is set, BuildFinished may
  contains FailureDetails -> CONFIGURATION_DISCARDED_ANALYSIS_CACHE.
  bazelbuild/bazel#16805

- ExecRequest event is included for `bazel run`
  bazelbuild/bazel@9a047de

- TestProgress event is included for TestRunner action
  bazelbuild/bazel@d8b8ab0

- ActionExecuted now includes start/end time and strategy information
  bazelbuild/bazel@2ddacab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants