-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[7.4.0] Fix inconsistent virtual include paths (#23361)
So far only the generated header in the virtual includes is tested but the Include path pointing to that directory isnt This is a testcase to reproduce the suspected error reported here: - #23061 Assuming that the location of the file is asserted: ```Java assertThat(artifactsToStrings(ccInfo.getCcCompilationContext().getDirectPublicHdrs())) .contains("bin third_party/bar/_virtual_includes/starlark_lib_suffix/starlark_lib.h"); ``` Adding a testcase for the include path seems reasonable. A local run of the testcase shows the error: ``` 1) testStripIncludePrefixIncludePath(com.google.devtools.build.lib.rules.cpp.StarlarkCcCommonTest) value of: getIncludeDirs().onlyElement() expected: bazel-out/k8-fastbuild/bin/third_party/bar/_virtual_includes/starlark_lib_suffix but was : bazel-out/k8-fastbuild/bin/third_party/bar/_virtual_includes/starlark_lib at com.google.devtools.build.lib.rules.cpp.StarlarkCcCommonTest.testStripIncludePrefixIncludePath(StarlarkCcCommonTest.java:5902) FAILURES!!! Tests run: 73, Failures: 1 ``` The change in behaviour was introduced in 7e0df68#diff-403c46ec3075b8e9e6d490ce955db88dae2d457b8046608884039b18b10ab6ccR774 Fixes: #23061 Closes #23071. PiperOrigin-RevId: 660681269 Change-Id: Ia3f8a8a6cf8bf0e093416a247e348e6de6719584 Closes #23221 Co-authored-by: FaBrand <[email protected]>
- Loading branch information
Showing
3 changed files
with
58 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters