-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Automated rollback of commit 990d97e.
*** Reason for rollback *** This is a roll forward CL which addressed the issue reported in b/289354550#comment9. I added another `LabelInterner#enabled()` method to check whether `globalPool` was set or not. If not, then `SkyframeExecutor` should not remove any labels from weak interner when PAKCAGE node is done. A unit test is also added to verify the condition when `LabelInterner#enable()` returns false. *** Original change description *** Automated rollback of commit 0bda661. *** Reason for rollback *** b/289354550 *** Original change description *** Clean up Label Interner flag and relevant unused code PiperOrigin-RevId: 545793223 Change-Id: I4254c6ed910e31c2702a26ddec9c334470f7e1bf
- Loading branch information
1 parent
6da7f21
commit 95c15c8
Showing
8 changed files
with
53 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 0 additions & 44 deletions
44
src/main/java/com/google/devtools/build/skyframe/UsePooledLabelInterningFlag.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters