[7.4.0] Precompute hashcode for RepositoryName. (#23697)

PiperOrigin-RevId: 676817381 Change-Id: I66b566ed75be858b3f2d92a8ac751bc97358a578 Commit 5949aac Co-authored-by: Googler <[email protected]>
bazelbuild · Sep 20, 2024 · 8716f50 · 8716f50
1 parent 577a3aa
commit 8716f50
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java b/src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java
@@ -20,6 +20,7 @@
 import com.google.common.base.Preconditions;
 import com.google.common.base.Throwables;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.SerializationConstant;
+import com.google.devtools.build.lib.util.HashCodes;
 import com.google.devtools.build.lib.util.Pair;
 import com.google.devtools.build.lib.util.StringCanonicalizer;
 import com.google.devtools.build.lib.util.StringUtilities;
@@ -138,13 +139,18 @@ public static Pair<RepositoryName, PathFragment> fromPathFragment(
    */
   @Nullable private final String didYouMeanSuffix;
 
+  private final int hashCode;
+
   private RepositoryName(
       String name,
       @Nullable RepositoryName ownerRepoIfNotVisible,
       @Nullable String didYouMeanSuffix) {
     this.name = name;
     this.ownerRepoIfNotVisible = ownerRepoIfNotVisible;
     this.didYouMeanSuffix = didYouMeanSuffix;
+    this.hashCode =
+        31 * OsPathPolicy.getFilePathOs().hash(name)
+            + HashCodes.hashObjects(ownerRepoIfNotVisible, didYouMeanSuffix);
   }
 
   private RepositoryName(String name) {
@@ -367,7 +373,6 @@ public boolean equals(Object object) {
 
   @Override
   public int hashCode() {
-    return Objects.hash(
-        OsPathPolicy.getFilePathOs().hash(name), ownerRepoIfNotVisible, didYouMeanSuffix);
+    return hashCode;
   }
 }