gazelle_runner: allow usage of transitive runfiles #1686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rebase of the work from @greenboxal to support the gazelle java extension use of runfiles to pull in the Java parser. Closes bazelbuild#828
|
@robfig @fmeum is this something you could have a look at? This would support the merge of bazel-contrib/rules_jvm#216 |
fmeum
requested changes
Dec 13, 2023
| @@ -27,7 +27,19 @@ source "${RUNFILES_DIR:-/dev/null}/$f" 2>/dev/null || \ | |||
|
|
|||
| @@GENERATED_MESSAGE@@ | |||
|
|
|||
| set -euo pipefail | |||
| # --- begin runfiles.bash initialization v3 --- | |||
There was a problem hiding this comment.
We already loaded this library in line 15. What does this duplication achieve?
| # --- end runfiles.bash initialization v3 --- | ||
|
|
||
| # Export runfile vars so sub-processes can access them | ||
| runfiles_export_envvars |
There was a problem hiding this comment.
This is invoked in line 113. Do we have to move it to an earlier line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
The gazelle bash runner.
What does this PR do? Why is it needed?
This is a rebase of the work from @greenboxal to support the gazelle java extension use of runfiles to pull in the Java parser.
Other notes for review
Closes #828