Skip to content

Commit

Permalink
Add gazelle-overrides for argo, grpcgateway (#1867)
Browse files Browse the repository at this point in the history
**What type of PR is this?**
Other

**What package or component does this PR mostly affect?**
bzlmod

**What does this PR do? Why is it needed?**
Adds default directives needed for some go libraries

**Other notes for review**
I realized we have some gazelle directives we use to make the listed
libs build. Adding it to the default overrides so I don't need it in our
libs.
  • Loading branch information
udaya2899 authored Aug 14, 2024
1 parent 15cd97e commit bc4ad6b
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions internal/bzlmod/default_gazelle_overrides.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ DEFAULT_BUILD_FILE_GENERATION_BY_PATH = {
}

DEFAULT_DIRECTIVES_BY_PATH = {
"github.com/argoproj/argo-workflows/v3": [
"gazelle:proto disable",
],
"github.com/argoproj/argo-events": [
"gazelle:proto disable",
"gazelle:go_naming_convention import_alias",
],
"github.com/census-instrumentation/opencensus-proto": [
"gazelle:proto disable",
],
Expand All @@ -31,6 +38,10 @@ DEFAULT_DIRECTIVES_BY_PATH = {
"github.com/cockroachdb/errors": [
"gazelle:proto disable",
],
"github.com/colinmarc/hdfs/v2": [
"gazelle:go_naming_convention import_alias",
"gazelle:proto disable",
],
"github.com/containerd/containerd": [
"gazelle:proto disable",
],
Expand Down Expand Up @@ -65,6 +76,11 @@ DEFAULT_DIRECTIVES_BY_PATH = {
"github.com/googleapis/gnostic": [
"gazelle:proto disable",
],
"github.com/grpc-ecosystem/grpc-gateway": [
"gazelle:resolve go github.com/grpc-ecosystem/grpc-gateway/internal //internal:go_default_library",
"gazelle:go_naming_convention import_alias",
"gazelle:proto disable",
],
"github.com/pseudomuto/protoc-gen-doc": [
# The build file in github.com/mwitkow/go-proto-validators has both go_proto and gogo_proto targets, but the checked
# in go files are generated by gogo proto. Resolving to the gogo proto target preserves the behavior of Go modules.
Expand Down

0 comments on commit bc4ad6b

Please sign in to comment.