Add stb #3469
Open
Add stb #3469
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazel-io skip_check unstable_url |
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (stb) have been updated in this PR. Please review the changes. |
bazel-io
added
the
skip-url-stability-check
fmeum
added
the
presubmit-auto-run
fmeum
reviewed
Dec 20, 2024
fmeum
reviewed
Dec 20, 2024
fmeum
reviewed
Dec 21, 2024
| cc_library( | ||
| name = "stb_image", | ||
| hdrs = ["stb_image.h"], | ||
| defines = ["STB_IMAGE_IMPLEMENTATION"], |
There was a problem hiding this comment.
Based on https://github.com/nothings/stb?tab=readme-ov-file#how-do-i-use-these-libraries, wouldn't all targets need to look like this?
cc_library(
name = "stb_thing",
hdrs = ["stb_thing.h"],
# A generated file that includes the header after defining `STB_THING_IMPLEMENTATION`.
srcs = ["stb_thing.c"],
...
)This would allow users to use the headers without having to worry about the "include in exactly one source file" bit. You could probably get away with an empty source file if you use local_defines to set the macro and -include to force inclusion of the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nothings/stb