Draft
[email protected] #2077
+268
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (ecclesia-machine-management) have been updated in this PR. Please review the changes. |
|
Can you please add usual labels ? |
fmeum
added
presubmit-auto-run
mmorel-35
force-pushed
the
[email protected]
branch
2 times, most recently
from
a7eb163 to
65a9c16
Compare
mmorel-35
force-pushed
the
[email protected]
branch
from
65a9c16 to
9ee03b7
Compare
|
@keith , |
|
looks like you need to patch in an empty BUILD file at the root of the repo since that repo has them in nested dirs but not at the root? |
mmorel-35
commented
Jun 6, 2024
There was a problem hiding this comment.
@keith ,
That's what is provided here.
Am I missing something ?
|
you should actually try and sidestep this entirely by using the bzlmod googleapis repo. if you don't it can lead to ODR violations since there will be 2 in the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by:
Related to google/ecclesia-machine-management#1114