Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using write_file from Bazel Skylib #778

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

luispadron
Copy link
Collaborator

Makes #776 a bit easier as one less rule to document and saves some code.

@luispadron luispadron force-pushed the luis/use-bazel-skylib-write_file branch from 2efa72c to 1346660 Compare October 16, 2023 23:14
@luispadron luispadron changed the base branch from master to luis/bump-bazel-to-6.3.2 October 16, 2023 23:14
Copy link
Collaborator

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This should probably be a major version bump since it removes a macro/rule.

@luispadron
Copy link
Collaborator Author

👏 This should probably be a major version bump since it removes a macro/rule.

Sounds good, I'll release a 3.0 bundled with the stardoc bzlmod upgrade (which also changes some api around bzl_library) and it'll be the first version released to the registry

Base automatically changed from luis/bump-bazel-to-6.3.2 to master October 17, 2023 01:05
Copy link
Collaborator

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - On a quick GH search, I couldn't find any public users of this API, but there still could presumably be some private ones. I don't feel super strongly about the major version bump personally, but not opposed to it either to follow semver to the letter. I don't think this was ever intended as part of the public API surface and is easily replaceable. It might be nice if we could be more strict about the public API surface so we don't end up needing to make a breaking API change for something like this.

@luispadron luispadron merged commit 70b497c into master Oct 17, 2023
8 checks passed
@luispadron luispadron deleted the luis/use-bazel-skylib-write_file branch October 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants