refactor: migrate to rules based toolchain #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
rules_based_toolchain
branch
from
4248bd4 to
f0ef928
Compare
|
@thesayyn Sorry, I forgot about this. Is this ready for review? |
|
@fmeum its not close to being done, but i'd really appreciate the early feedback here. I am committed to land this and some more. |
|
@thesayyn Took me a while not the general approach looks good to me. I like to see a workaround for bazelbuild/rules_cc#277 - have you tried to upstream it? This repo currently reuses the toolchain config from rules_cc. Is your plan to no longer do this or to also migrate the default toolchain to the new rules? Either would be fine, just curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, #444