sphinxdoc: move tests and docs to module-root directory#3690
Merged
rickeylev merged 4 commits intobazel-contrib:mainfrom Apr 10, 2026
Merged
sphinxdoc: move tests and docs to module-root directory#3690rickeylev merged 4 commits intobazel-contrib:mainfrom
rickeylev merged 4 commits intobazel-contrib:mainfrom
Conversation
This just moves the tests and docs to the "top level", so that the layout resembles the more normal layout where e.g. tests are at the top level.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request restructures the sphinxdocs project by updating package paths, adjusting visibility for Starlark libraries, and adding a new integration test for BCR. A review comment suggests reverting the visibility change for the private package to maintain better encapsulation.
aignas
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so the file layout has the more idiomatic top-level "docs" and "tests" directories.