Skip to content

fix: update the stub type alias names #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update the stub type alias names #2929

wants to merge 1 commit into from

Conversation

kaycebasques
Copy link
Collaborator

No description provided.

kaycebasques
kaycebasques commented May 23, 2025
View reviewed changes
Copy link
Collaborator Author

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the note in the template PR to update the changelog. Seemed like this may be too minor to note so I omitted a changelog update.

tools/precompiler/precompiler.py
@@ -68,12 +68,12 @@ def _compile(options: "argparse.Namespace") -> None:
# A stub type alias for readability.
# See the Bazel WorkRequest object definition:
# https://github.com/bazelbuild/bazel/blob/master/src/main/protobuf/worker_protocol.proto
JsonWorkerRequest = object
JsonWorkRequest = object
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the type hints below seem to expect JsonWorkRequest not JsonWorkerRequest

tools/precompiler/precompiler.py

# A stub type alias for readability.
# See the Bazel WorkResponse object definition:
# https://github.com/bazelbuild/bazel/blob/master/src/main/protobuf/worker_protocol.proto
JsonWorkerResponse = object
JsonWorkResponse = object
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the type hints below seem to expect JsonWorkResponse not JsonWorkerResponse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@aignas aignas Awaiting requested review from aignas aignas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaycebasques @rickeylev