Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support loading tarballs with older podman #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nholstein
Copy link

Older versions of Podman appear to handle loading a tarball differently depending upon with the input is /dev/stdin or not. In particular:

podman load --input <(cat foo.tar)

raises an error, while:

cat foo.tar | podman load

works without error. (Podman loads from stdin if no --input is specified.)

This enables support for podman v3.4.4 included in Ubuntu 22.04.

fixes #711

@thesayyn
Copy link
Collaborator

This is a breaking change unfortunately. It changes invocation of the underlying binary from docker load -i to docker load | input

@nholstein
Copy link
Author

@thesayyn, thanks for looking into this and you feedback. I wasn't aware that this was a breaking change under Docker; my understanding was that docker supports the same tar $FILES | docker load semantics.

Can you suggest an alternate approach I could investigate that would be compatible?

@thesayyn
Copy link
Collaborator

It's a breaking change for rules_oci to change how we invoke the loader cli, it could podman or docker or some shell script user wrote. If we change it from -i to stdin, it's a breaking change.

Older versions of Podman appear to handle loading a tarball differently
depending upon with the input is /dev/stdin or not. In particular:

    podman load --input <(cat foo.tar)

raises an error, while:

    cat foo.tar | podman load

works without error. (Podman loads from stdin if no --input is specified.)

This enables support for podman v3.4.4 included in Ubuntu 22.04.

fixes bazel-contrib#711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oci_load incompatible with older version of Podman
2 participants